Skip to content
This repository has been archived by the owner on Apr 21, 2024. It is now read-only.

Make it stable #62

Open
innonguyen opened this issue Oct 21, 2021 · 2 comments
Open

Make it stable #62

innonguyen opened this issue Oct 21, 2021 · 2 comments

Comments

@innonguyen
Copy link

Dear Thomas,

I think you should includes and fix something to make it stable version. Here're what I found:

  1. These following dependencies should not be devDependencies because your library won't work without it. You should keep it in list of dependencies.
  • expo-image-manipulator
  • expo-gl
  • recoil
  1. ImagePicker.requestCameraRollPermissionsAsync() is deprecated in favour of ImagePicker.requestMediaLibraryPermissionsAsync()

You can replace it in your home instruction in readme file.

Hope it helps

@Joshmatjjen
Copy link

True @innonguyen . this need to be adjusted I had to install those Libary one after the other

@ajenkins
Copy link

I agree that recoil should definitely be in the dependencies. However, expo-gl and expo-image-manipulator are already listed in peerDependencies. That does mean that you need to install those yourself, but that's kind of what peerDependencies is for. The Readme should probably call out that you need to install those yourself though. I submitted a PR to add recoil and react-native-gesture-handler to dependencies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants