Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use the word "Light" as color context #49

Open
beazcandido opened this issue Sep 6, 2022 · 7 comments
Open

Unable to use the word "Light" as color context #49

beazcandido opened this issue Sep 6, 2022 · 7 comments

Comments

@beazcandido
Copy link

Hello!

Right now in the project that I'm working on we have 3 modes: Light, Dark and High Contrast and inside those we have colors that include the name Light as its context (e.g. Foreground Light, Background Light).

But we realized that themer's new version does not allow these colors to be converted, maybe because of the use of Light as both mode and context. Themer's previous version used to allow them to be converted, so we were wondering if there is a way to make that possible again.

@thomas-lowry
Copy link
Owner

Hey! Can you share the names of your theme, and some examples of the fill names of your styles including the folder structure/prefixes?

@Ivy-Y
Copy link

Ivy-Y commented Sep 6, 2022

Hello @thomas-lowry - I work on the same team as @beazcandido. To answer your question, the names of our theme are "High Contrast", "Dark" and "Light".

image

Here is a sample screenshot of a few color styles we have in the light and dark themes.

image

I created a little gif to demonstrate the problem. Our theory is that the styles that's not converting are the ones containing the same letter nodes to their parent theme (in this case "Light"). We tried changing their names from "Light" to something else such as "Lt", and they started converting again.

themer-test

@thomas-lowry
Copy link
Owner

This is super helpful!!! Actively working on this and have an idea what is happening. Keep you posted here.

@thomas-lowry
Copy link
Owner

Hey @Ivy-Y @beazcandido would you be able to try again and report back. I improved some things about my method of finding matching names. It's hard to explain in few words why this is kind of complex but it should work now. Can you confirm?

@beazcandido
Copy link
Author

@thomas-lowry Thank you so much, it works perfectly now!

image

@Ivy-Y
Copy link

Ivy-Y commented Sep 8, 2022

Thanks a lot for fixing this @thomas-lowry! Works on my end also. 😄

@andreigarcia
Copy link

Thank you so much for your support and quick improvement @thomas-lowry!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants