Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple excluded networks #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support multiple excluded networks #156

wants to merge 1 commit into from

Conversation

koorgoo
Copy link

@koorgoo koorgoo commented Nov 13, 2020

Closes #155.

@stale
Copy link

stale bot commented Nov 28, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 28, 2020
@koorgoo
Copy link
Author

koorgoo commented Nov 28, 2020

Noop comment not to close the issue.

@stale stale bot removed the stale label Nov 28, 2020
@topas-rec
Copy link

I hope it was fun to create this fix.
It saved me a lot of work - thank you.

I want to report test results for this change.

I created bandwidth limiting for incoming and outgoing connections of an interface.
After that I added five source and five destination networks as exclusions per direction (five excluded networks for incoming and five excluded networks per outgoing)

I verified the result by transferring data

  • out of an excluded network into an excluded network and by
  • transferring data into and out of a non-excluded network into and out of an excluded network.

The results say that the traffic between excluded networks was not limited, while the traffic to networks that were not excluded was limited.

In short: it works for my use case.

Suggesting to merge this, since it is very helpful for bandwidth management at routers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple excluded networks
3 participants