Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate starkware/math #5

Open
thor314 opened this issue Nov 1, 2023 · 3 comments
Open

Migrate starkware/math #5

thor314 opened this issue Nov 1, 2023 · 3 comments
Labels

Comments

@thor314
Copy link
Owner

thor314 commented Nov 1, 2023

Migrate math.

Relatively self-contained, only about 300 lines of code.

@agnxsh
Copy link

agnxsh commented Nov 2, 2023

https://docs.rs/num-traits/0.2.17/num_traits/ any thoughts about this? it should have the things like modular arithmetic.

@thor314
Copy link
Owner Author

thor314 commented Nov 3, 2023

maybe overkill; many of these methods already exist in the standard library, or are accessible through a finite-field trait, I think Arkworks is re-exporting from num_traits, might b better to use ark_ff instead unless there's a specific reason to use num-traits

@agnxsh
Copy link

agnxsh commented Nov 3, 2023

sure that works as well, okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants