Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Dockerfile doesn't work with flightdeck #1189

Open
minaslater opened this issue Apr 18, 2024 · 3 comments
Open

Generated Dockerfile doesn't work with flightdeck #1189

minaslater opened this issue Apr 18, 2024 · 3 comments
Labels
Enhancement Features we're considering adding

Comments

@minaslater
Copy link

On a recent project with Lift-Off, I had trouble deploying the image that's built from the Suspenders generated Dockerfile (which I assume is the Rails default) to the thoughtbot flightdeck platform. The state of that project was as follows:

  • Empty Suspenders-generated application
  • Baseline flightdeck buildout AWS platform (no Control Tower, multi-account or SSO)

I can add more specifics once I have some time to dig into it, but due to project time crunch, we replaced the Dockerfile with one that we know for sure works on flightdeck, with small application-specific tweaks, and that was deployed successfully.

Since Suspenders and flightdeck are both thoughtbot products, it'd be nice for them to get along out of the box.

@stevepolitodesign
Copy link
Contributor

Thank you for opening this.

the Suspenders generated Dockerfile (which I assume is the Rails default)

This is correct. The generated Dockerfile is indeed created from Rails.

Since Suspenders and flightdeck are both thoughtbot products, it'd be nice for them to get along out of the box.

I agree. Would it be as simple as having Suspenders generate this Dockerfile instead?

@minaslater
Copy link
Author

I agree. Would it be as simple as having Suspenders generate this Dockerfile instead?

I think it can be! Definitely a straightforward solution.

Although, I'll probably still want to figure out what was causing the issues anyway, but that shouldn't block your new release.

@stevepolitodesign
Copy link
Contributor

I'll probably still want to figure out what was causing the issues anyway, but that shouldn't block your new release.

Awesome, for now I'll probably continue forward with the new release, but I think this would make for a good follow-up.

@stevepolitodesign stevepolitodesign added the Enhancement Features we're considering adding label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Features we're considering adding
Projects
None yet
Development

No branches or pull requests

2 participants