Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bootcamp Task] Remove thumbor upload into its own project #20

Open
heynemann opened this issue Jan 30, 2022 · 0 comments
Open

[Bootcamp Task] Remove thumbor upload into its own project #20

heynemann opened this issue Jan 30, 2022 · 0 comments
Labels
L3 Level 3 Bootcamp Task maintainability Tasks related to improving maintainability (tests, refactoring, ...) python Python related tasks task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor.

Comments

@heynemann
Copy link
Member

Areas of Expertise

thumbor, open-source, testing, python, maintainability

Creating your own open source project will teach a lot of the concepts required for participating in another's open source project. Great experience!

Summary

Create a new project thumbor-upload in thumbor's org and move the upload functionality into it. Once it has been moved, create a L2 task here to remove upload from thumbor's codebase (or do it in two PRs yourself).

Involved Modules

Don't forget to also check the tests and docs on uploading.

Task Relevance

Removing code from thumbor's codebase is as important as adding. The leaner the project is, the faster we can move and onboard new people.

Further Details

When you pick up this task, tag @heynemann to create the project for you and add you to the project team of contributors.

Then:

  • Create the structure to run tests
  • Add tests
  • Add code
  • Add github action to run the code on commit
  • Add linting
  • Add linting to the github action
  • Add a nice README explaining how to use this new extensions
  • Tag a version 0.1.0 (git tag 0.1.0 && git push --tags)
  • Ask @heynemann to submit to pypi and he'll add you to the list of maintainers.

Task Workflow

To complete this task, follow this workflow:

  1. Fork the involved repositories
  2. In each repository there's a documentation on how to install dependencies and initialize your environment
  3. Hack, in no particular order:
    • Write code & tests
    • Write new tests
    • Write docs
    • Improve design
    • Check that all tests pass
    • Repeat until you're satisfied
  4. Submit a pull request.
@heynemann heynemann added task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor. L3 Level 3 Bootcamp Task python Python related tasks maintainability Tasks related to improving maintainability (tests, refactoring, ...) labels Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L3 Level 3 Bootcamp Task maintainability Tasks related to improving maintainability (tests, refactoring, ...) python Python related tasks task Bootcamp task. Feel free to grab it and work on it. For more information ping a bootcamp mentor.
Projects
None yet
Development

No branches or pull requests

1 participant