Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoneless angular support #916

Open
banned007 opened this issue Jun 7, 2024 · 5 comments
Open

Zoneless angular support #916

banned007 opened this issue Jun 7, 2024 · 5 comments

Comments

@banned007
Copy link

Please add support for zoneless angular, maybe a new package/repo for this? not sure how to proceed, I have a working version of zoneless (literlly just removed the calls of zone functions, and it seemed to work right out) on my fork, but not sure if this is something you should include in the main package or if you want to create a new one for supporting this feature.

@banned007
Copy link
Author

@tiberiuzuld
Copy link
Owner

Hello,
Thank you for trying this. Was also curious if it will work.
I normally wait till the feature is stable in angular before integrating in the library.
Will see if it's possible to have it as a config option or make a branch with a separate version in npm.

@banned007
Copy link
Author

banned007 commented Jun 7, 2024

Hmm I don't think a config option is feasible, as you would need to remove zone.js from the peerDeps (because is not a dependency on zoneless), and when you inject it, you might get some injection dependency issues, so I think the most straight forward approach would be to just publish a new package.
also maybe having signals in the html would eliminate the need for having the ChangeDetectionRef.markForCheck call, but this could be implemented in a subsequent version of zoneless?

@tiberiuzuld
Copy link
Owner

tiberiuzuld commented Jun 7, 2024

Yes you are right, the most viable solution I see is to make a branch with the changes and make a version with zoneless and signals, something like 18.0.0-z to be published on npm.

Will see when I would have the time for this, most probably next week.

@tiberiuzuld
Copy link
Owner

New version 18.0.0-z is on npm https://www.npmjs.com/package/angular-gridster2/v/18.0.0-z
Will add signals and remove the change detection at a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants