Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-predict for some prediction types #29

Closed
topepo opened this issue Mar 5, 2021 · 5 comments
Closed

multi-predict for some prediction types #29

topepo opened this issue Mar 5, 2021 · 5 comments
Labels
feature a feature request or enhancement

Comments

@topepo
Copy link
Member

topepo commented Mar 5, 2021

With glmnet (and maybe mboost) we can get predictions one many values of some tuning parameters without multiple model fits. parsnip saves those as nested tibbles per row of new_data.

This is also how we store the predictions of hazard and survival probabilities.

We might be able to accommodate both by having a single nested for both. For example, for glmnet, we would have the full grid of penalty and .time values with an additional column for the prediction.

@hfrick hfrick added the feature a feature request or enhancement label Apr 16, 2021
@hfrick
Copy link
Member

hfrick commented Jun 29, 2021

#70 covers multi_predict() for glmnet's Cox models for the prediction types "survival" and "linear_pred".

@hfrick
Copy link
Member

hfrick commented May 9, 2022

todo: type = "time" for glmnet

@hfrick
Copy link
Member

hfrick commented Apr 5, 2023

possible todo: mboost

@hfrick
Copy link
Member

hfrick commented Jan 3, 2024

Added the remaining prediction types of glmnet models in #282 , and am going to close this issue in favor of a new one specifically for mboost: #290

@hfrick hfrick closed this as completed Jan 3, 2024
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants