Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in geom-map.R #6163

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Typo in geom-map.R #6163

wants to merge 2 commits into from
+2 −2

Conversation

jonocarroll
Copy link
Contributor

Minor typo in documentation.

@teunbrand
Copy link
Collaborator

teunbrand commented Oct 26, 2024 •
edited
Loading

/document

EDIT:
Hi Jonathan, sorry the automatic document command doesn't seem to be working. Would you mind running devtools::document() to regenerate the .Rd files?

@jonocarroll
Copy link
Contributor Author

Interesting; shouldn't the .Rd files be generated artefacts and thus whatever is committed is redundant? In any case, I've re-generated and committed the relevant file.

@teunbrand
Copy link
Collaborator

Thanks for the update!
AFAIK we have no mechanism in place to automate regenerating the docs.
I think {gtable} has had a recent update that borks some tests that fail.
These are unrelated to your PR, so I'll approve this and merge when we've updated the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teunbrand teunbrand teunbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonocarroll @teunbrand