Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ggplot2 scales for agg_key structure #141

Closed
mitchelloharawild opened this issue Dec 3, 2019 · 3 comments
Closed

Add ggplot2 scales for agg_key structure #141

mitchelloharawild opened this issue Dec 3, 2019 · 3 comments
Labels
wait This issue is waiting for changes in upstream packages

Comments

@mitchelloharawild
Copy link
Member

Should correctly format <aggregated> in facets.

@mitchelloharawild
Copy link
Member Author

As far as I can tell, this needs to wait for ggplot2/scales to use vctrs more.

In particular,

@mitchelloharawild mitchelloharawild added the wait This issue is waiting for changes in upstream packages label Jan 13, 2020
@mitchelloharawild
Copy link
Member Author

An alternate solution (likely required for any timely release) is to write ScaleAggDiscrete for aggregated discrete scales. Largely inherit from ggplot2::ScaleDiscrete.

@mitchelloharawild
Copy link
Member Author

Consolidated into #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wait This issue is waiting for changes in upstream packages
Projects
None yet
Development

No branches or pull requests

1 participant