Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely slow augment() in my mable #208

Open
edgBR opened this issue Jun 1, 2020 · 6 comments
Open

Extremely slow augment() in my mable #208

edgBR opened this issue Jun 1, 2020 · 6 comments

Comments

@edgBR
Copy link

edgBR commented Jun 1, 2020

Dear colleagues,

I have a grouped ts_tibble where I am fitting ETS, TSLM, ARIMA, NNETAR and a combination model using all of this 4:

ts_models <- ts_tibble %>% 
  model(arima = ARIMA(snsr_val_clean),
        nnarx = NNETAR(snsr_val_clean),
        tslm = TSLM(snsr_val_clean ~ trend()),
        ets = ETS(snsr_val_clean),
        ensemble_full =  combination_model(ARIMA(snsr_val_clean),
                                           NNETAR(snsr_val_clean),
                                           TSLM(snsr_val_clean ~ trend()),
                                           ETS(snsr_val_clean)))

The fitting takes 486.989s according to tictoc() and runs in paralell without problems (I am loading purrr+furrr+future). However when trying to inspect the mable object as:

augment(ts_models)
It has been running for 1h and a half in single core and I can not access the results.

BR
/Edgar

@mitchelloharawild mitchelloharawild transferred this issue from tidyverts/fable Jun 1, 2020
@mitchelloharawild
Copy link
Member

I've moved this to fabletools as this is likely due to the combination handling in fabletools. It might also be due to the residuals() and fitted() methods for the fable models, which are due for some performance improvements this week.
Can I ask how many series are in your ts_tibble?

@edgBR
Copy link
Author

edgBR commented Jun 1, 2020

Hi @mitchelloharawild

I have 4273 time series in weekly frequency. However it seemed to me interesting that the fitting was faster than getting the residuals.

BR
/Edgar

@mitchelloharawild
Copy link
Member

Performance improvements have been made in b6b336c, and further improvements are coming.

@edgBR
Copy link
Author

edgBR commented Jun 21, 2020

Hi @mitchelloharawild thanks for the update.

Is 0.2.0 already in CRAN?

@mitchelloharawild
Copy link
Member

Yes it is.

@edgBR
Copy link
Author

edgBR commented Jul 2, 2020

Still really slow as well as my_models %>% accuracy()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants