Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forecast.mbl() gains a new argument names_to = ".model"? #96

Open
earowang opened this issue Jul 22, 2019 · 9 comments
Open

forecast.mbl() gains a new argument names_to = ".model"? #96

earowang opened this issue Jul 22, 2019 · 9 comments

Comments

@earowang
Copy link
Member

hence we can easily rename the .model column.

@mitchelloharawild mitchelloharawild added this to the v0.2.0 milestone Jul 22, 2019
@mitchelloharawild
Copy link
Member

Sounds reasonable, although ".model" is assumed in a variety of places (plotting, accuracy, etc.). It will probably need to be stored as an attribute of the fbl_ts

@earowang
Copy link
Member Author

isn't it part of key?

@mitchelloharawild
Copy link
Member

Yes, but ".model" is treated differently from key in some places. For example when plotting, the model is used for the colour, other keys are row facets, and response variable (if multivariate) are column facets.

@earowang
Copy link
Member Author

can setdiff() work out the difference?

@mitchelloharawild
Copy link
Member

Difference from what? The original tsibble keys aren't stored, just the current ones (inclusive of .model).
Perhaps in the plot it could be used as the data may be available, although it is possible to plot the forecasts without data.

@mitchelloharawild
Copy link
Member

.model is also used with augment(), glance(), tidy(), etc.
Should all these functions gain this argument?

@earowang
Copy link
Member Author

I think so, whenever to "longer" format.

Can we just have model instead of mdl_nm?

@mitchelloharawild
Copy link
Member

Consolidated into #192

@mitchelloharawild
Copy link
Member

Reopening as I don't have time to include this in today's release, which closes #192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants