Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider class for ACF lag column #82

Open
mitchelloharawild opened this issue Dec 2, 2019 · 4 comments
Open

Reconsider class for ACF lag column #82

mitchelloharawild opened this issue Dec 2, 2019 · 4 comments
Labels

Comments

@mitchelloharawild
Copy link
Member

From #70

Use a difftime to represent lags instead of the cf_lag class.
Store the interval elsewhere for plot breaks.

@mitchelloharawild
Copy link
Member Author

@earowang
I don't think difftime can be used because it doesn't support irregular units such as months. Does this sound reasonable?

@AEBilgrau
Copy link

Hi, I was about to make an issue in respect. I lack some functionality for either type conversion/coercion or cf_lag handling in general. The current class is a bit cumbersome in the downsteam analysis and e.g. wanting to use other plotting libraries than ggplot2. What are your thoughts on this?

@mitchelloharawild
Copy link
Member Author

I have ideas for a new temporal vctrs object for handling temporal aggregation (tidyverts/fabletools#59).
This new temporal class will also support origin-less time offsets which ACF will use.
It will have also have scales methods so it should work with ggplot2.

@mitchelloharawild
Copy link
Member Author

Wait for https://github.com/mitchelloharawild/moment to provide origin-less time structures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants