Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display locations on conference list #532

Merged
merged 11 commits into from
Jan 21, 2025
Merged

Conversation

andrewmile
Copy link
Collaborator

This PR closes #519 by adding the conference location to the conferences list page. This PR also adds a app:backfill-conference-location-names to backfill a display-friendly conference location. Each conference listing will then display either the conference's location name, or the value in the location column, if present.

image

app/CallingAllPapers/ConferenceImporter.php Outdated Show resolved Hide resolved
app/Console/Commands/BackfillConferenceLocationNames.php Outdated Show resolved Hide resolved
app/Services/Geocoder.php Outdated Show resolved Hide resolved
Copy link
Member

@mattstauffer mattstauffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@mattstauffer
Copy link
Member

Wonderful work, great to merge @andrewmile!

@andrewmile andrewmile merged commit 284e974 into develop Jan 21, 2025
2 checks passed
@andrewmile andrewmile deleted the ajm/display-location branch January 21, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would LOVE to see "Location" on the conference index page.
2 participants