Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.accountsDF() error with single account #79

Open
danielgrzenda opened this issue Apr 27, 2020 · 1 comment
Open

client.accountsDF() error with single account #79

danielgrzenda opened this issue Apr 27, 2020 · 1 comment
Labels
tests Issues related to tests

Comments

@danielgrzenda
Copy link
Contributor

danielgrzenda commented Apr 27, 2020

A dictionary is returned from client.accounts(). When calling client.accountsDF() with a single account this throws an error, because json_normalize expects a group of records.

@dahifi dahifi added the bug Concrete, reproducible bugs label Apr 29, 2020
@dahifi dahifi added tests Issues related to tests and removed bug Concrete, reproducible bugs labels May 21, 2020
@dahifi
Copy link
Collaborator

dahifi commented May 21, 2020

@danielgrzenda this is fixed in current master.

I'm not going to close it because there's no test coverage. Should just be as simple as adding


            m.return_value.json.return_value = [{'test': 1}]
            tdclient.accountsDF()

to the end of testclient.test_accounts.

dahifi added a commit that referenced this issue May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues related to tests
Projects
None yet
Development

No branches or pull requests

2 participants