-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webapp: user who turns off computer hangs forever online #66
Comments
That is only possible if Alice's computer is still using internet connection while in hybernation, which is usually not the case.
That is certainly not the case. The most likely reason is that (in terms of users you have described), Bob's webapp lost the notification from Alice. |
Probably. Today Alice hybernated computer and immediately appeared as offline on Bob's phone. But Bob's phone's screen was on. I will try to test it again when phone's screen is off. |
I'm certain the problem is in Bob's client. It's quite simple. When Bob reconnects, he gets the list of subscriptions and |
The problem, however, exists. Scenario N 1 Alice hybernates her computer. Bob's phone screen is ON and he is active in the webapp. Alice's status changes to "offline" as soon as she hybernates computer. Scenario N 2 Bob is active in the webapp. Then he turn's phone's screen off but leaves the webapp open. While Bob's phone screen is off, Alice hybernates computer. When Bob turns phone's screen on again, he sees that Alice is still online. Bob performs various activities - send messages in other topics, return to the contacts list but Alice's status doesn't change - she is still online. Bob's phone loses Internet connection. While webapp reconnects, the status of Alice for a moment changes to "offline" but after reconnecting Alice is online again. Comments Correct online/offline status of users is a very important thing in every messenger. If it doesn't work properly, it doesn't make any sense at all. I don't know Reactjs and can not send pull requests or something but i't the thing that should be fixed in some way. I guess Tinode's webapp should perform some actions like online/offline status, reconnection timeout based on visibilityChange event. I have another post about this problem. I have my computer on all day and web.whatsapp.com is open in some browser's tab. I see messages coming to me, but I know I won't show up online until the tab with whatsapp is active (visible). If it were otherwise, I would not have opened the whatsapp. If a person sees that you're online but you don't reply to messages, what can think? In case of Tinode's webapp it does not actually show if user is online (is using the webapp) but whether the computer is turned on with Tinode's webapp openeted in some tab. |
I agree there is a bug in Bob's reconnect: Bob's webapp does not clear Alice's You also describe a feature to show user |
So, fake online status is displayed now. Turned on compuer does not mean that a person is using computer, and
Yes, |
I must repeat: please open a separate issue for your feature request. This issue is about a bug. It will be closed when the bug is fixed. Your discussion of the feature will be lost. I will not comment on your feature request here. |
Sorry, I just answered to your message about fake |
Probably fixed in tinode/tinode-js@a96b82b |
Have you had a chance to check if it's fixed? I'm going to make 0.17.0 release next week. |
I tested it yesterday. Looks that the problem is fixed. |
It's not actally a bug and not a feature request but a problem that should be fixed to avoid confusing situations between users.
Alice uses webapp in Windows 97 computer, Chrome browser.
Dave uses webapp in Android phone, Chrome browser.
Alice and Dave are chatting and then Alice turns off (hibernates) her computer without closing browser.
Dave sees that Alice is still online and send one more message. Alice does not answer.
After 1 hour Dave still sees that Alice is online. Send a message but Alice does not answer.
The same after 3 hours.
Then Bob closes the webapp in his phone and opens it again. Now he sees that Alice has been seen 3 hours ago.
So, the problem is the following: user who turns off (hibernates) computer will be visible as "online" until the recipient reloads the application.
Incorrect online status display was already described here. User should not be "online" if browser's tab with Tinode is not active (visible) because turned on computer does not mean that user is using using computer or Tinode's webapp.
The situation where an user is seen online even if his computer is turned off is even more strange.
The text was updated successfully, but these errors were encountered: