Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrade, my initial command is not executed #24

Open
sandordargo opened this issue Mar 5, 2022 · 3 comments
Open

After upgrade, my initial command is not executed #24

sandordargo opened this issue Mar 5, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@sandordargo
Copy link

When you want to execute a command and tipi offers an update, at the end of the update the original command is not executed.

To give a concrete example.
I want to run tipi connect. Tipi went on with an update from v.0.0.27 to v.0.0.28. When it finished with the update, it didn't run tipi connect.

It would be nice if it went on with the original command.

@daminetreg
Copy link
Contributor

Thanks for the report.

I think we also have a bug that the install scripts installs as root and that the upgrade is run by the user.

Which might make the tipi --force-upgrade to fail and what’s bad currently is that it might not be obvious that it failed.

Yannic is already investigating, we should be able to pack a fix for that soon.

@daminetreg daminetreg added bug Something isn't working enhancement New feature or request labels Mar 6, 2022
@daminetreg
Copy link
Contributor

We improved the update process, it still doesn't run the command that was entered but in v0.0.32 we made it work better and with nicer message that one needs to rerun the command afterward.

Still looking to make the enhancement and will reach back here in a future version

@daminetreg daminetreg removed the bug Something isn't working label Jun 22, 2022
@daminetreg
Copy link
Contributor

I think we also have a bug that the install scripts installs as root and that the upgrade is run by the user.

To make it clear, this has all been fixed #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants