Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chromium] failed to access specific tag #55

Open
pcorbineau opened this issue Feb 1, 2023 · 4 comments
Open

[Chromium] failed to access specific tag #55

pcorbineau opened this issue Feb 1, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@pcorbineau
Copy link

pcorbineau commented Feb 1, 2023

Hey guys,
I want to test your build system with a complex example build.

For this I test to build a specific version of https://github.com/chromiumembedded/cef/ that required https://github.com/chromium/chromium as dependency.

I write this .tipi/deps file :

{
    "chromiumembedded/cef": {
        "@": "5481",
        "requires": {
            "chromium/chromium": {
                "@": "110.0.5481.0"
            }
        }
    }
}

I can access to specific tag https://github.com/chromium/chromium/tree/110.0.5481.0 but tipi failed to get it.

PS C:\Users\pcorbineau\Documents\personal_workspace\tipi_sandbox> tipi -t windows .
Looking for 4 files
Found cache meta
 - Checking cache status for: chromiumembedded/cef<605475778197b8725fc2659a58859cc46974516b> ⚙️ update required
chromiumembedded/cef up-to-date check.
- done.
 ⚙️ querying and downloading cache for chromiumembedded/cef@: 5481 [605475778197b8725fc2659a58859cc46974516b]
- done.
Fetching : https://github.com/chromiumembedded/cef.git
- done.
chromiumembedded/cef@: 5481 [605475778197b8725fc2659a58859cc46974516b]
Looking for 2115 files
chromium/chromium up-to-date check.
- done.
● [err] Dynamic exception type: class std::runtime_error
std::exception::what: err : error:0 OKstatus: 502 accessing : https://api.github.com/repos/chromium/chromium/git/refs/tags
● [err] Something went wrong, for help on your issue, we would enjoy getting your report at https://tipi.build/#contact

Any idea how to deal with it ?

Here is the simple code to test it :

#include <iostream>

#include <include/cef_process_message.h>

int main(){
  auto message = CefProcessMessage::Create("test");

  auto args = message->GetArgumentList();
  args->SetString(0, "Hello");
  args->SetString(1, "World");

  auto arg0 = args->GetString(0);
  auto arg1 = args->GetString(1);

  std::cout << arg0 << " " << arg1 << std::endl;

  return 0;
}
@daminetreg
Copy link
Contributor

daminetreg commented Feb 1, 2023

Thanks for the great report, it seems that the specific tag is not on any branch which seems to get our clone implementation based on libgit2 to fail.

I think tipi will not be able to compile Cef with source scan as of today and need some special cmake middleware to get it right, but your specific issue you reported can definitely be fixed in changing the way we clone repositories.

@daminetreg
Copy link
Contributor

We will dig into that and reach back.

@daminetreg daminetreg added the bug Something isn't working label Feb 1, 2023
@pcorbineau
Copy link
Author

chromium builds are so big that your build system could be a game changer 🙏

@daminetreg
Copy link
Contributor

chromium builds are so big that your build system could be a game changer 🙏

Thanks, we have users doing it with the chromium build system and using the cloud build nodes via the command :

tipi -t linux -j128 .run chrome-build-cmd

But then you don’t get our caching and all the speed up, only the cpu counts. We are going to make it work out of the box, we will reach back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants