Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.tip/deps with invalid entries does not produce an error #73

Open
matthew-dews opened this issue Oct 6, 2023 · 4 comments
Open

.tip/deps with invalid entries does not produce an error #73

matthew-dews opened this issue Oct 6, 2023 · 4 comments

Comments

@matthew-dews
Copy link

Hi,

in .tipi/deps I had

"google/googletest": {
        "u": true,
        "package": "GTest"
    },

this produced a CMake error because I wrote package instead of packages. I think that having an incorrect entry in .tipi/deps should produce a hard error, otherwise it's easy to lose a lot of time troubleshooting the wrong problem.

@daminetreg
Copy link
Contributor

I feel so sorry for this issue, thanks for sharing with me after the talk here at CppCon, we are reworking the UX and these kinds of issues should be pointed out by our system.

Are you building exclusively with a CMakeLists or are you building your own app without ?

@matthew-dews
Copy link
Author

I am building without CMakelists.txt currently. You can see the code here: https://github.com/matthew-dews/tipi-build-starter/tree/f8d53d16a6eb0075bee33b3b893fc69fd3ce8375

GoogleTest automatic test detection isn't working properly, I think I need to add some CMakeLists.txt, but the repo in that state shows how GoogleTest is being included.

@daminetreg
Copy link
Contributor

Thank you for sending the link to this complete set of goals and examples.

Regarding GoogleTest yes for it to work properly for the moment you would need a use-cmake.tipi file and an appropriate CMakeLists.txt in the test folder to register them.

We will see what we can do to enable automatic detection without CMake and reach back.

@daminetreg
Copy link
Contributor

Hello @matthew-dews I added a PR to show you how best this could be solved with GTest and Boost : matthew-dews/tipi-build-starter#1

It uses GTest via a use-cmake.tipi in the test folder and it imports Boost in the best way ( that can benefit properly from the cache ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants