Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add academicons.min.css to template #9

Open
aramirezreyes opened this issue Nov 21, 2021 · 4 comments
Open

Add academicons.min.css to template #9

aramirezreyes opened this issue Nov 21, 2021 · 4 comments

Comments

@aramirezreyes
Copy link

Hi! Following up from a post in slack.
Adding this set of "academic related" icons could be beneficial for this template:

https://jpswalsh.github.io/academicons/

@tlienart
Copy link
Owner

sorry what do you mean? making a reference to one of the many icon options like font awesome or academicons etc or actively using one of those in the template? if the latter; where would you add the logos on the template?

As I said to @kescobo a while back; I'm willing to help have this template be a good non-buggy "base" for people who want an academic-like website but beyond that I'm personally not inclined to add things that some users may want, some not, and which are easy to add separately. I hope that makes sense

@kescobo
Copy link
Contributor

kescobo commented Nov 21, 2021

Perhaps for some stuff like this, building out the README with some guidance on how to add it would be a good compromise.

@aramirezreyes
Copy link
Author

Thanks! Yes, I completely understand. I posted these issues following our conversation in slack where you said:

easiest is if you see specific things that you would like to have and open one issue per item so that we can work at it gradually. Most of the things you describe are basically just bootstrap elements so looking at the HTML of the source page you link to is enough to know what's needed and including it in the franklin-version is very easy.

I definitely didn't want so appear entitled to you doing extra work! My apologies if it sounded like that.

@tlienart
Copy link
Owner

no need to apologise, I didn't take it badly at all!

I think the conclusion for this issue could be to add a link in the index.md where you would add a section "how to use XYZ icons, for instance the academicons are particularly useful" and you could show how to insert the relevant stylesheet link in the _layout/head.html ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants