Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure library.jl #39

Open
tlnagy opened this issue Jun 30, 2016 · 0 comments
Open

Restructure library.jl #39

tlnagy opened this issue Jun 30, 2016 · 0 comments
Assignees

Comments

@tlnagy
Copy link
Owner

tlnagy commented Jun 30, 2016

Due to some poor designing on my part, the Library type in library.jl is monolithic and fragile. It would be much better to have this as two separate types, Genome and Library. Then this new slimmed down Library type could be integrated with the already existing Cas9behavior type. Separately, num_genes and num_guides should be moved from the Screen types into Genome.

Additionally, instead of the hackish thing I'm doing here: https://github.com/tlnagy/pooled-screen-optimization/blob/41ff08519ad9775733c26552d43e1649d0962008/src/simulation/library.jl#L68-L83 with the combination of dictionaries and categorical distributions, I could use Types to encompass this information and make the whole thing cleaner.

@tlnagy tlnagy self-assigned this Jun 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant