Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Screens/index: full line is not highlighted for certain item fields #83

Open
tmplt opened this issue Apr 20, 2019 · 2 comments
Open

Screens/index: full line is not highlighted for certain item fields #83

tmplt opened this issue Apr 20, 2019 · 2 comments
Labels
bug tui this issue regards the text-based user-interface
Milestone
v0.9.0

Comments

@tmplt
Copy link
Owner

tmplt commented Apr 20, 2019

For certain strings (e.g. Birkhäuser) the whole selected line is not highlighted. For Birkhäuser specifically, the first character after the string is not reversed; see image below.
@tmplt tmplt added bug tui this issue regards the text-based user-interface labels Apr 20, 2019
@tmplt
Copy link
Owner Author

tmplt commented Apr 21, 2019

Could this be related to the umlaut?

@tmplt
Copy link
Owner Author

tmplt commented Jun 30, 2019

Can be replicated with the string Throne of Jade (®) which also contains a non-ASCII character.

@tmplt tmplt added this to the v0.9.0 milestone Jul 8, 2019
tmplt added a commit that referenced this issue Jul 8, 2019
@tmplt
WIP: fix(screens/index): correctly print Unicode strings
aea5273 
this fix should probably be applied elsewhere.
Fix inefficient code, etc.

Resolves #83
tmplt added a commit that referenced this issue Jul 9, 2019
@tmplt
fix(screens/index): correctly handle Unicode strings
c61c036 
This fix is likely to apply elsewhere, but we'll tackle those issues
when we find them, so that we do not accidentaly introduce new bugs.

Resolves #83
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug tui this issue regards the text-based user-interface
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
1 participant
@tmplt