From 867b58a46c547c84c29baef73421054dc2284c37 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20H=C3=A4ggstr=C3=B6m?= <kalvdans@gmail.com>
Date: Fri, 4 Nov 2016 16:49:18 +0100
Subject: [PATCH] Open files in read-only mode when they should only be read
 from

---
 h5read.cc | 21 ++++++++++++---------
 h5read.h  |  3 ++-
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/h5read.cc b/h5read.cc
index f346fd5..00b634e 100644
--- a/h5read.cc
+++ b/h5read.cc
@@ -170,7 +170,7 @@ the appropriate size for the given HDF5 type.\n\
     return octave_value_list ();
 
   //open the hdf5 file
-  H5File file (filename.c_str (), false);
+  H5File file (filename.c_str (), false, false);
   if (error_state)
     return octave_value_list ();
 
@@ -244,7 +244,7 @@ is to read.\n\
     return octave_value_list ();
   
   //open the hdf5 file
-  H5File file (filename.c_str (), false);
+  H5File file (filename.c_str (), false, false);
   if (error_state)
     return octave_value_list ();
         
@@ -318,7 +318,7 @@ the appropriate size for the given Octave type.\n\
   if (nargin == 3)
     {
       //open the hdf5 file, create it if it does not exist
-      H5File file (filename.c_str (), true);
+      H5File file (filename.c_str (), true, true);
       if (error_state)
         return octave_value_list ();
       file.write_dset (location.c_str (),
@@ -327,7 +327,7 @@ the appropriate size for the given Octave type.\n\
   else  
     {
       //open the hdf5 file, complain if it does not exist
-      H5File file (filename.c_str (), false);
+      H5File file (filename.c_str (), false, true);
       if (error_state)
         return octave_value_list ();
 
@@ -397,7 +397,7 @@ the object named @var{objectname} in the HDF5 file specified by @var{filename}.\
     return octave_value_list ();
     
   //open the hdf5 file
-  H5File file (filename.c_str (), false);
+  H5File file (filename.c_str (), false, true);
   if (error_state)
     return octave_value_list ();
 
@@ -513,7 +513,7 @@ setting is not @sc{matlab} compatible.\n\
   
   
   //open the hdf5 file
-  H5File file (filename.c_str (), true);
+  H5File file (filename.c_str (), true, true);
   if (error_state)
     return octave_value_list ();
   file.create_dset (location.c_str (), size, datatype.c_str (), chunksize);
@@ -568,7 +568,7 @@ Note that this function is not @sc{matlab} compliant.\n\
     return octave_value_list ();
 
   //open the hdf5 file
-  H5File file (filename.c_str (), true);
+  H5File file (filename.c_str (), true, true);
   if (error_state)
     return octave_value_list ();
   if (nargin == 2)
@@ -586,7 +586,8 @@ Note that this function is not @sc{matlab} compliant.\n\
 
 #if defined (HAVE_HDF5) && defined (HAVE_HDF5_18)
 
-H5File::H5File (const char *filename, const bool create_if_nonexisting)
+H5File::H5File (const char *filename, const bool create_if_nonexisting,
+		const bool write_access)
 {
   H5E_auto_t oef;
   void *olderr;
@@ -606,7 +607,9 @@ H5File::H5File (const char *filename, const bool create_if_nonexisting)
         error ("The file is not in the HDF5 format, %s: %s", filename, strerror (errno));
       else
         {
-          file = H5Fopen (filename, H5F_ACC_RDWR, H5P_DEFAULT);
+          file = H5Fopen (filename,
+			  write_access ? H5F_ACC_RDWR : H5F_ACC_RDONLY,
+			  H5P_DEFAULT);
           if (file < 0)
             error ("Opening the file failed, %s: %s", filename, strerror (errno));
         }
diff --git a/h5read.h b/h5read.h
index ba5361d..813ba4d 100644
--- a/h5read.h
+++ b/h5read.h
@@ -39,7 +39,8 @@ class H5File
   
  public:
   
-  H5File (const char *filename, const bool create_if_nonexisting);
+  H5File (const char *filename, const bool create_if_nonexisting,
+	  const bool write_access);
   
   ~H5File ();