Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insufficient warning for provideCT, editCT, claimCT #56

Open
suahnkim opened this issue Aug 9, 2024 · 1 comment
Open

Insufficient warning for provideCT, editCT, claimCT #56

suahnkim opened this issue Aug 9, 2024 · 1 comment
Assignees
@zzooppii
Labels
serverity: LOW Upgrade syntax or code efficiency

Comments

@suahnkim
Copy link
Contributor

suahnkim commented Aug 9, 2024

crossTrade/contracts/L1/L1CrossTrade.sol

Line 56 in a92ad15

function provideCT(

Please add enough warning for provideCT, editCT, claimCT, as they can be executed from the contract without request transaction from L2.

See an example interface explanation provided Optimsm's code
@suahnkim suahnkim added the serverity: LOW Upgrade syntax or code efficiency label Aug 9, 2024
zzooppii added a commit that referenced this issue Aug 14, 2024
@zzooppii
feat Insufficient warning for provideCT, editCT, claimCT #56
3b0dfa5 
add notice WARING
@zzooppii
Copy link
Member

@suahnkim
Added WARING to L1's provideCT, cancel, and editFee respectively. Please check if the wording is appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zzooppii zzooppii

Labels
serverity: LOW Upgrade syntax or code efficiency
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@suahnkim @zzooppii