Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong assert stack level #74

Open
TIMONz1535 opened this issue Nov 9, 2022 · 0 comments · Fixed by Ismoh/local-lua-debugger-vscode#10
Open

Wrong assert stack level #74

TIMONz1535 opened this issue Nov 9, 2022 · 0 comments · Fixed by Ismoh/local-lua-debugger-vscode#10

Comments

@TIMONz1535
Copy link

TIMONz1535 commented Nov 9, 2022 •
edited
Loading

Hello, I see that when the assert is triggered, I fall into a function inside the plugin, which is very annoying. It seems useless.

изображение

Look above, by default the debuggerError function has a stack level (1) + 1 #51
Well, if I change the stack level inside debuggerAssert to 2, everything will work as expected

изображение
изображение

Is it possible to do this by default?
jaymo1011 added a commit to jaymo1011/local-lua-debugger-vscode that referenced this issue Mar 30, 2024
@jaymo1011
fix: handle assert() correctly
f233464 
Fixes tomblind#74 by starting the trace one level deeper, skipping over `debuggerAssert` as was likely intended.
@jaymo1011 jaymo1011 mentioned this issue Mar 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect assert() handling jaymo1011/local-lua-debugger-vscode
1 participant
@TIMONz1535