Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd Glasgow numeric formatting on 2020-04-12 #35

Closed
timday opened this issue Apr 12, 2020 · 1 comment
Closed

Odd Glasgow numeric formatting on 2020-04-12 #35

timday opened this issue Apr 12, 2020 · 1 comment

Comments

@timday
Copy link

timday commented Apr 12, 2020

Note the last record:

$ grep Glasgow data/covid-19-cases-uk.csv | tail
2020-04-03,Scotland,S08000031,Greater Glasgow and Clyde,779
2020-04-04,Scotland,S08000031,Greater Glasgow and Clyde,851
2020-04-05,Scotland,S08000031,Greater Glasgow and Clyde,931
2020-04-06,Scotland,S08000031,Greater Glasgow and Clyde,984
2020-04-07,Scotland,S08000031,Greater Glasgow and Clyde,1094
2020-04-08,Scotland,S08000031,Greater Glasgow and Clyde,1166
2020-04-09,Scotland,S08000031,Greater Glasgow and Clyde,1251
2020-04-10,Scotland,S08000031,Greater Glasgow and Clyde,1314
2020-04-11,Scotland,S08000031,Greater Glasgow and Clyde,1387
2020-04-12,Scotland,S08000031,Greater Glasgow and Clyde,"1,449"

Seems a bit odd to suddenly switch the way numbers are formatted. Again, nothing that can't be dealt along with the 1 to 4 and NaN type things, and it's perfectly well formed CSV... but it does seem a bit odd when that region has never done the comma thousands numeric formatting thing before (and none of the other regions with counts over 1000 does either I think).

@tomwhite
Copy link
Owner

@timday thanks for reporting this. I agree it's inconsistent, and have fixed the data and the underlying code so that commas are removed from numbers for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants