Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a New DB option to make DB temporary #91

Open
ethe opened this issue Aug 19, 2024 · 3 comments
Open

a New DB option to make DB temporary #91

ethe opened this issue Aug 19, 2024 · 3 comments
Assignees
@caicancai
Labels
enhancement New feature or request good first issue Good for newcomers S - Small Fixing small bugs, adjusting UI styles, optimizing existing functions.

Comments

@ethe
Copy link
Member

ethe commented Aug 19, 2024 •
edited
Loading

In current, initialize DB would always create a persistant folder, it is annoying in some cases, such as testing db in CI. I think create a new option temporary, Always clean all files or folders when DB is dropped, should be useful in this case.
@ethe ethe added enhancement New feature or request good first issue Good for newcomers labels Aug 19, 2024
@caicancai
Copy link
Contributor

caicancai commented Aug 19, 2024 •
edited
Loading

Can you let me try it? I've started this part of the work over the weekend

@ethe
Copy link
Member Author

ethe commented Aug 19, 2024

Sure, I am glad to hear that

@caicancai
Copy link
Contributor

Since I am a rust beginner, I am learning rust and this pr may take a little time

@KKould KKould added the S - Small Fixing small bugs, adjusting UI styles, optimizing existing functions. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caicancai caicancai

Labels
enhancement New feature or request good first issue Good for newcomers S - Small Fixing small bugs, adjusting UI styles, optimizing existing functions.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ethe @caicancai @KKould