[WIP] handle hiding labels and line markers separately #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RE: Tests - I was not able to get the Docker testing framework to run. I ran the tests locally and saw a large number of failures. Looking at the graphs, they were essentially the same, so I am hopping Travis will see no failures. There might be an issue with the graphs I added for new tests as it seems likely my setup is generating the graphs ever so slightly different than the Docker setup would. |
Refactored Gruff::Base #setup_graph_measurements to use private methods to calculate each measurement. This moves the intertwined calculations based on hidden aspects of the graph to separate methods to make the decision points easier to follow.
elrayle
changed the title
… parameters The parameters for this method changed when it moved from `Gruff::Base #render_gradated_background` to `Gruff::Renderer #gradated_background`. The rescue retry was not updated to retry with the new set of parameters. This commit fixes that. **Related Work:** PR #357 - refactor: Move setup phase of RMagick object into Gruff::Renderer
|
Closing: PR #446 adds this functionality for bar charts only. It establishes a pattern that can be used for other graph types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Work in Progress -- DO NOT MERGE
The initial refactor of
Gruff::Base #setup_graph_measurementshas been moved to PR #444 which is green and ready for merge. This PR has been rebased on PR #444 and waiting for tests to complete to determine whether there are test failures related to the new processing of@hide_labelsand@hide_line_markers.Fixes #139
Description
@hide_labels(new) - hides column labels whether they appear under the graph or to the left of the graph.@hide_line_markers- code modified to only hide line markers and base hiding of labels on new @hide_labelsAdded tests for bar, line, and dot. Dot was used to test labels on the left instead of the bottom.
Related Work:
PR #444 - refactor Gruff::Base #setup_graph_measurements to reduce complexity