Skip to content
This repository was archived by the owner on Jan 24, 2025. It is now read-only.

healthcheck in docker file need a shell #401

Closed
amm123 opened this issue Dec 8, 2021 · 2 comments
Closed

healthcheck in docker file need a shell #401

amm123 opened this issue Dec 8, 2021 · 2 comments

Comments

@amm123
Copy link

amm123 commented Dec 8, 2021

current health check will alway give unhealthy as it cannot access the ${PORT} without shell ( also it will no know what is the '||' without a shell)
therefore it will always fail and docker will report unhealthy status
it should use the shell command instead of the exec array.

CMD [ "curl" , "-f" "localhost:${PORT}", "||", "exit", "1"]

should be
CMD curl -f localhost:${PORT} || exit 1

5a8d52a

@konstrybakov
Copy link

Hi @amm123, thanks for taking your time to open this issue, if you feel like this could be a beneficial addition to the project, you are welcome to open a PR with your suggestions!

@konstrybakov
Copy link

Hi @amm123 Healthcheck issue was resolved by #389

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants