Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-query): make @suspensive/react-query v2 all naming convention correctly like @tanstack/react-query v5 #401

Merged
merged 77 commits into from
Jan 21, 2024

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Nov 25, 2023

fix #253

Overview

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@manudeli manudeli self-assigned this Nov 25, 2023
Copy link

changeset-bot bot commented Nov 25, 2023

🦋 Changeset detected

Latest commit: e4e5ef5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@suspensive/react-query Major
@suspensive/visualization Patch
@suspensive/react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
beta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 9:54am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 9:54am
docs-v1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 9:54am
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 9:54am
main ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 9:54am
visualization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2024 9:54am

@vercel vercel bot temporarily deployed to Preview – visualization November 26, 2023 00:04 Inactive
@vercel vercel bot temporarily deployed to Preview – docs November 26, 2023 00:05 Inactive
@manudeli manudeli force-pushed the react-query/fix/unify-interface-names branch from cbc855e to 22a78d4 Compare November 26, 2023 06:28
@vercel vercel bot temporarily deployed to Preview – docs November 26, 2023 06:29 Inactive
Copy link

codesandbox-ci bot commented Nov 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vercel vercel bot temporarily deployed to Preview – docs November 26, 2023 07:14 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization November 26, 2023 07:16 Inactive
@vercel vercel bot temporarily deployed to Preview – docs November 26, 2023 07:30 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization November 26, 2023 07:31 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization November 26, 2023 11:36 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization November 26, 2023 20:33 Inactive
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Merging #401 (e4e5ef5) into beta (20b5378) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             beta     #401   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files          27       27           
  Lines         406      406           
  Branches      103      103           
=======================================
  Hits          343      343           
  Misses         55       55           
  Partials        8        8           
Components Coverage Δ
@suspensive/react 96.78% <ø> (ø)
@suspensive/react-query 0.00% <0.00%> (ø)
@suspensive/react-await 100.00% <ø> (ø)
@suspensive/react-image 23.52% <ø> (ø)

@vercel vercel bot temporarily deployed to Preview – docs November 26, 2023 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – docs November 26, 2023 20:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs November 26, 2023 20:53 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization January 17, 2024 12:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 17, 2024 12:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v1 January 17, 2024 12:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v1 January 19, 2024 08:17 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization January 19, 2024 08:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 19, 2024 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v1 January 20, 2024 07:29 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization January 20, 2024 07:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 January 20, 2024 07:32 Inactive
@manudeli manudeli changed the base branch from main to beta January 21, 2024 09:45
@vercel vercel bot temporarily deployed to Preview – beta January 21, 2024 09:49 Inactive
@manudeli manudeli marked this pull request as ready for review January 21, 2024 09:50
@vercel vercel bot temporarily deployed to Preview – beta January 21, 2024 09:51 Inactive
@manudeli manudeli changed the title fix(react-query): @suspensive/react-query all naming convention correctly like v5 fix(react-query): make @suspensive/react-query v2 all naming convention correctly like @tanstack/react-query v5 Jan 21, 2024
@vercel vercel bot temporarily deployed to Preview – visualization January 21, 2024 09:53 Inactive
@vercel vercel bot temporarily deployed to Preview – main January 21, 2024 09:54 Inactive
Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@manudeli
Copy link
Member Author

LGTM 😄

Long time no see @okinawaa! Let's go to @suspensive/react-query v2

@manudeli manudeli merged commit d06e883 into beta Jan 21, 2024
19 checks passed
@manudeli manudeli deleted the react-query/fix/unify-interface-names branch January 21, 2024 16:35
@github-actions github-actions bot mentioned this pull request May 14, 2024
manudeli pushed a commit that referenced this pull request May 14, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to beta, this PR will
be updated.


# Releases
## @suspensive/[email protected]

### Major Changes

- [#632](#632)
[`ea1c4ed`](ea1c4ed)
Thanks [@manudeli](https://github.com/manudeli)! - feat(react): rename
Suspensive defaultOptions -> defaultProps

- [#629](#629)
[`78f5bd4`](78f5bd4)
Thanks [@manudeli](https://github.com/manudeli)! - feat(react,
react-query): remove deprecated apis

- [#629](#629)
[`6a3f6f4`](6a3f6f4)
Thanks [@manudeli](https://github.com/manudeli)! - feat(react): remove
ErrorBoundaryGroup.Reset

- [#629](#629)
[`36d7416`](36d7416)
Thanks [@manudeli](https://github.com/manudeli)! - chore(\*): versioning
last beta

- [#629](#629)
[`73c0cc7`](73c0cc7)
Thanks [@manudeli](https://github.com/manudeli)! - fix(react): add
getServerSnapShot in syncDevMode

- [#631](#631)
[`837ed18`](837ed18)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): remove
target react v16, v17

### Patch Changes

- [#755](#755)
[`3f6171b`](3f6171b)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): remove all
experimental interface

## @suspensive/[email protected]

### Major Changes

- [#629](#629)
[`78f5bd4`](78f5bd4)
Thanks [@manudeli](https://github.com/manudeli)! - feat(react,
react-query): remove deprecated apis

- [#401](#401)
[`d06e883`](d06e883)
Thanks [@manudeli](https://github.com/manudeli)! - fix(react-query):
@suspensive/react-query v2's all naming convention correctly like
@tanstack/react-query v5

- [#629](#629)
[`36d7416`](36d7416)
Thanks [@manudeli](https://github.com/manudeli)! - chore(\*): versioning
last beta

- [#631](#631)
[`837ed18`](837ed18)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): remove
target react v16, v17

### Minor Changes

- [#828](#828)
[`7f19c76`](7f19c76)
Thanks [@manudeli](https://github.com/manudeli)! - feat(react-query):
add queryOptions

- [#775](#775)
[`785a51a`](785a51a)
Thanks [@manudeli](https://github.com/manudeli)! - feat(react-query):
add SuspenseQuery, SuspenseInfiniteQuery

### Patch Changes

- Updated dependencies
\[[`ea1c4ed`](ea1c4ed),
[`78f5bd4`](78f5bd4),
[`6a3f6f4`](6a3f6f4),
[`36d7416`](36d7416),
[`3f6171b`](3f6171b),
[`73c0cc7`](73c0cc7),
[`837ed18`](837ed18)]:
    -   @suspensive/[email protected]

## @suspensive/[email protected]

### Patch Changes

- [#631](#631)
[`837ed18`](837ed18)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): remove
target react v16, v17

## @suspensive/[email protected]

### Patch Changes

- [#631](#631)
[`837ed18`](837ed18)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): remove
target react v16, v17

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: @suspensive/react-query all naming convention correctly like v5
2 participants