Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(react-image): rename Image -> SuspenseImage #554

Merged
merged 2 commits into from
Jan 4, 2024
Merged

refactor(react-image): rename Image -> SuspenseImage #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f77e8dd
refactor(react-image): rename Image -> SuspenseImage
manudeli Jan 4, 2024
a7e5ea4
Create sour-geese-do.md
manudeli Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sour-geese-do.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@suspensive/react-image": patch
---

refactor(react-image): rename Image -> SuspenseImage
7 changes: 5 additions & 2 deletions packages/react-image/src/Image.tsx → packages/react-image/src/SuspenseImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import { type ComponentProps, forwardRef } from 'react'
import { useLoad } from './Load'

type ImageProps = ComponentProps<'img'>
export const Image = forwardRef<HTMLImageElement, ImageProps>(function Image({ src, ...props }, ref) {
type SuspenseImageProps = ComponentProps<'img'>
export const SuspenseImage = forwardRef<HTMLImageElement, SuspenseImageProps>(function SuspenseImage(
{ src, ...props },
ref
) {
if (typeof src !== 'string') {
throw new Error('Image of @suspensive/react-image requires src')
}
Expand Down
2 changes: 1 addition & 1 deletion packages/react-image/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { Image } from './Image'
export { SuspenseImage } from './SuspenseImage'
10 changes: 5 additions & 5 deletions websites/visualization/src/app/react-image/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
'use client'

import { wrap } from '@suspensive/react'
import { Image } from '@suspensive/react-image'
import { SuspenseImage } from '@suspensive/react-image'

export default wrap
.ErrorBoundary({ fallback: () => <div>error</div> })
.Suspense({ clientOnly: true, fallback: 'loading...' })
.on(function Page() {
return (
<div className="flex flex-col">
<Image src="https://placehold.co/200x100" />
<Image src="https://placehold.co/200" />
<Image src="https://placehold.co/200x150/000000/FFFFFF/png" />
<Image src="https://placehold.co/200x150?text=Hello+World" />
<SuspenseImage src="https://placehold.co/200x100" />
<SuspenseImage src="https://placehold.co/200" />
<SuspenseImage src="https://placehold.co/200x150/000000/FFFFFF/png" />
<SuspenseImage src="https://placehold.co/200x150?text=Hello+World" />
</div>
)
})
Loading