Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsup): remove treeshaking, minification #584

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Jan 10, 2024

fix: #583

Overview

@relsunkaev

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: 50e13f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@suspensive/react Patch
@suspensive/react-query Patch
@suspensive/react-await Patch
@suspensive/react-image Patch
@suspensive/visualization Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 10, 2024

Deployment failed with the following error:

Resource is limited - try again in 7 hours (more than 100, code: "api-deployments-free-per-day").

@manudeli manudeli self-assigned this Jan 10, 2024
Copy link

vercel bot commented Jan 10, 2024

Deployment failed with the following error:

Resource is limited - try again in 6 hours (more than 100, code: "api-deployments-free-per-day").

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Merging #584 (50e13f9) into main (e8adf42) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   84.18%   84.18%           
=======================================
  Files          29       29           
  Lines         468      468           
  Branches      108      108           
=======================================
  Hits          394      394           
  Misses         64       64           
  Partials       10       10           
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-query 0.00% <ø> (ø)
@suspensive/react-await 100.00% <ø> (ø)
@suspensive/react-image 23.52% <ø> (ø)

@manudeli manudeli marked this pull request as ready for review January 10, 2024 01:24
@manudeli manudeli merged commit 9bced99 into main Jan 10, 2024
16 checks passed
@manudeli manudeli deleted the fix/remove-treeshaking-minification branch January 10, 2024 01:25
manudeli added a commit that referenced this pull request Jan 10, 2024
fix: #583

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

 @relsunkaev

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

Co-authored-by: Ramazan Elsunkaev <[email protected]>
@minsoo-web
Copy link
Member

I wonder what the problem is that you deleted it!

manudeli added a commit that referenced this pull request Aug 3, 2024
fix: #583

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

 @relsunkaev

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

Co-authored-by: Ramazan Elsunkaev <[email protected]>
manudeli added a commit that referenced this pull request Aug 3, 2024
fix: #583

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

 @relsunkaev

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix: #583

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

 @relsunkaev

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

Co-authored-by: Ramazan Elsunkaev <[email protected]>
manudeli added a commit that referenced this pull request Aug 3, 2024
fix: #583

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

 @relsunkaev

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.

Co-authored-by: Ramazan Elsunkaev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: forwardRef is not defined client-side error in Next.js production builds
2 participants