Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge report #5

Open
xNok opened this issue Mar 1, 2019 · 1 comment
Open

Merge report #5

xNok opened this issue Mar 1, 2019 · 1 comment

Comments

@xNok
Copy link

xNok commented Mar 1, 2019

I think it will be nice to be able to be able to generate a report of which keys have been change as a result of the merge.

I don't known the best way to implement such a feature, so I open this ussie to talk about it.

There is three element to collect:

  • path
  • inital value
  • new value

We don't want the implement something in each strategy so the solution sould be able to intercept the deepest change (in terms of path) and printing it.

@toumorokoshi
Copy link
Owner

Yeah, this may be difficult. An audit report would be cool: I would imagine you could feed in a data structure to store such merge information alongside the object you want to merge, that is responsible for collecting that data.

I think as long as performance isn't affected in the case you don't want a report, I'm happy to take a PR and merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants