Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traefik-crds is using unexpected meta.helm.sh/release-namespace annotation #1337

Closed
2 tasks done
shinebayar-g opened this issue Feb 9, 2025 · 2 comments · Fixed by #1338
Closed
2 tasks done

traefik-crds is using unexpected meta.helm.sh/release-namespace annotation #1337

shinebayar-g opened this issue Feb 9, 2025 · 2 comments · Fixed by #1338
Labels
kind/question Further information is requested

Comments

@shinebayar-g
Copy link
Contributor

Welcome!

  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What version of the Traefik's Helm Chart are you using?

1.2.0

What version of Traefik are you using?

3.3.2

What did you expect to happen ?

CustomResourceDefinition without meta.helm.sh/release-namespace annotation since they're global resources.

What did you notice instead ?

I'm using traefik-crds to deploy CRDs separately. However, it seems, CustomResourceDefinition output file is containing meta.helm.sh/release-namespace annotation which seems unnecessary. On top of that, the value is using $scope.Release.Namespace which defaults to the current kube config namespace which leads to inconsistent output.

What are your values ?

No values.

Additional Information

@shinebayar-g shinebayar-g changed the title traefik-crds is using unexpected meta.helm.sh/release-namespace value traefik-crds is using unexpected meta.helm.sh/release-namespace annotation Feb 9, 2025
@mloiseleur mloiseleur added kind/bug/possible a possible bug that needs analysis before it is confirmed or fixed. kind/question Further information is requested and removed status/0-needs-triage kind/bug/possible a possible bug that needs analysis before it is confirmed or fixed. labels Feb 10, 2025
@mloiseleur
Copy link
Member

Hello @shinebayar-g ,

Thanks for this detailed issue.
As far as I remember, it's required for helm to handle those resources.
It's consistent: it's the the name and the namespace of the helm release that is handling that global resource.

Feel free to open a PR if you need to remove them and you think you have found a way to handle those resources with helm without those annotations.

@shinebayar-g
Copy link
Contributor Author

As far as I remember, it's required for helm to handle those resources.

Where did you get that information? kube-prometheus-stack-crds chart doesn't use it. In fact, I don't recall this annotation being used.

It's consistent: it's the the name and the namespace of the helm release that is handling that global resource.

No it's not consistent. If --namespace flag is not supplied by user, it looks up kube config and use whatever namespace is set. So it's not idempotent.

I created a PR here #1338

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants