support HTTP 429 rate limiting #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the initial implementation of the rate limiting based on http 413 was based on https://transloadit.com/blog/2012/04/introducing-rate-limiting/ but some time after that, the api seems to have changed to instead reply 429, and now rate limiting seems to be broken, as evident by some tests failing. this code adds support for rate limiting 429 (in addition to 413)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #217 +/- ##
==========================================
- Coverage 68.36% 68.31% -0.06%
==========================================
Files 6 6
Lines 588 587 -1
Branches 113 113
==========================================
- Hits 402 401 -1
Misses 186 186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation of the rate limiting based on http 413 was based on
https://transloadit.com/blog/2012/04/introducing-rate-limiting/
but some time after that, the api seems to have changed to instead reply 429,
and now rate limiting seems to be broken, as evident by some tests failing.
this code adds support for rate limiting 429 (in addition to 413)