From 4146283f90263bce53f4353758a0f8540bc758a7 Mon Sep 17 00:00:00 2001 From: Ivan Shvedunov Date: Mon, 18 Oct 2021 20:06:22 +0300 Subject: [PATCH] e2e: fix monitoring time test instability In order for all of the reports to have non-zero volume, more precise timing is needed, which is hard to achieve in the current CI environment. --- test/e2e/upg_e2e.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/e2e/upg_e2e.go b/test/e2e/upg_e2e.go index 97dcb3c..3393822 100644 --- a/test/e2e/upg_e2e.go +++ b/test/e2e/upg_e2e.go @@ -638,9 +638,7 @@ var _ = ginkgo.Describe("[Reporting]", func() { gomega.Expect(beforeSplit.EndTime).To(gomega.Equal(monitoringTime)) gomega.Expect(afterSplit.StartTime).To(gomega.Equal(monitoringTime)) gomega.Expect(beforeSplit.TotalVolume).NotTo(gomega.BeNil()) - gomega.Expect(*beforeSplit.TotalVolume).NotTo(gomega.BeZero()) gomega.Expect(afterSplit.TotalVolume).NotTo(gomega.BeNil()) - gomega.Expect(*afterSplit.TotalVolume).NotTo(gomega.BeZero()) ul, dl := getTrafficCountsFromCapture(f, layers.IPProtocolUDP, nil) framework.ExpectEqual(firstUL+*beforeSplit.UplinkVolume+*afterSplit.UplinkVolume, ul, @@ -742,11 +740,9 @@ var _ = ginkgo.Describe("[Reporting]", func() { gomega.Expect(before.EndTime).To(gomega.Equal(monitoringTimes[n])) gomega.Expect(after.StartTime).To(gomega.Equal(monitoringTimes[n])) gomega.Expect(before.TotalVolume).NotTo(gomega.BeNil(), "total volume before (report %d)", n) - gomega.Expect(*before.TotalVolume).NotTo(gomega.BeZero(), "total volume before (report %d)", n) framework.ExpectEqual(*before.UplinkVolume+*before.DownlinkVolume, *before.TotalVolume, "bad total volume (split %d)", n) gomega.Expect(after.TotalVolume).NotTo(gomega.BeNil(), "total volume after (report %d)", n) - gomega.Expect(*after.TotalVolume).NotTo(gomega.BeZero(), "total volume after (report %d)", n) framework.ExpectEqual(*after.UplinkVolume+*after.DownlinkVolume, *after.TotalVolume, "bad total volume (split %d)", n)