Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: zig/protobuf-zig/: No such file or directory #11

Open
travisstaloch opened this issue Jun 18, 2024 · 6 comments
Open

ci: zig/protobuf-zig/: No such file or directory #11

travisstaloch opened this issue Jun 18, 2024 · 6 comments

Comments

@travisstaloch
Copy link
Owner

https://github.com/travisstaloch/protobuf-zig/actions/runs/9559522253/job/26350006190

Not sure whats causing this. Could be the change to https://github.com/mlugg/setup-zig.

TODO - get rid of the sdk step stuff in build.zig and instead do something like https://ziglang.org/learn/build-system/#running-the-projects-tools

@mindon
Copy link

mindon commented Aug 9, 2024

it seems the zig-out/bin/protoc is not executable
-rw-r--r-- protoc

@travisstaloch
Copy link
Owner Author

Oh thank you! That sounds like it might be the issue. I guess that either zig's zip impl or the build system doesn't preserve file executable bits. So they would have to be manually set.

@travisstaloch
Copy link
Owner Author

it seems the zig-out/bin/protoc is not executable -rw-r--r-- protoc

@mindon I can't reproduce on linux. What OS are you seeing this from?

$ rm -rf .zig-cache/ zig-out/ && zig build && ls -lah zig-out/bin/
-rwxrwxr-x 1 9.0M Aug  9 15:11 protoc

@mindon
Copy link

mindon commented Aug 12, 2024

it seems the zig-out/bin/protoc is not executable -rw-r--r-- protoc

@mindon I can't reproduce on linux. What OS are you seeing this from?

$ rm -rf .zig-cache/ zig-out/ && zig build && ls -lah zig-out/bin/
-rwxrwxr-x 1 9.0M Aug  9 15:11 protoc

I'm using M1 with MacOS Sonoma 14.4.1 (23E224), zig (0.14.0-dev) build failure on following error
error: unable to spawn /Users/hello/protobuf-zig/zig-out/bin/protoc: AccessDenied

@travisstaloch
Copy link
Owner Author

travisstaloch commented Aug 12, 2024

Hmm not sure why this is happening. Could you try manually downloading the files from https://github.com/protocolbuffers/protobuf/releases/download/v27.0/protoc-27.0-osx-universal_binary.zip and check if the unzipped files are executable? This way we could check if this is a problem with their zip files.

@travisstaloch
Copy link
Owner Author

Don't worry about my last request @mindon. I asked about this on discord and it seems like execute permissions support hasn't been added to the zig zip implementation yet. I created an issue for this ziglang/zig#21044.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants