Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve display syscall verification #4273

Open
TychoVrahe opened this issue Oct 21, 2024 · 0 comments
Open

Improve display syscall verification #4273

TychoVrahe opened this issue Oct 21, 2024 · 0 comments
Labels
code Code improvements

Comments

@TychoVrahe
Copy link
Contributor

Followup for #4229

The current verifiers display_fill__verified and display_copy_rgb565__verified are not checking the destination write access.

We need to ensure that these functions cannot be misused to write outside of designated framebuffer area by improperly set bitblt structure.

See also #4229 (comment)
@TychoVrahe TychoVrahe added the code Code improvements label Oct 21, 2024
@TychoVrahe TychoVrahe mentioned this issue Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code Code improvements
Projects
Firmware
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TychoVrahe