Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(suite): send form token select #14799

Draft
wants to merge 21 commits into
base: develop
Choose a base branch
from
Draft

feat(suite): send form token select #14799

wants to merge 21 commits into from
+1,099 −586

Conversation

enjojoy
Copy link
Contributor

@enjojoy enjojoy commented Oct 10, 2024 •
edited
Loading

Description

  • Improved UI of token selection in send form.
  • Copy token contract address in the tooltip.
  • Implemented new modal instead of a dropdown

Related Issue

Resolve #13749

Screenshots:

Before:

image

After:

-if the network doesn't support tokens (for ex. Bitcoin)
image

  • Native token (no contract address):
    image
  • Token with a contract address:
    image
  • Tooltip:
    image
  • Modal (hidden and unverified tokens are excluded):
    image

@enjojoy enjojoy force-pushed the feat/token-select-element branch 12 times, most recently from e3506f0 to 97a6d36 Compare October 14, 2024 12:28
@enjojoy enjojoy force-pushed the feat/token-select-element branch 7 times, most recently from 206e84f to 672f0c8 Compare October 18, 2024 09:22
@adderpositive
Copy link
Contributor

adderpositive commented Oct 23, 2024 •
edited
Loading

I have found only this strange design. Not sure it is a related issue.
obrazek

@enjojoy
Copy link
Contributor Author

enjojoy commented Oct 23, 2024

I have found only this strange design. Not sure it is a related issue. obrazek

AFAIK @adamhavel fixed this, probably not on develop yet

@adamhavel
Copy link
Contributor

I have found only this strange design. Not sure it is a related issue. obrazek

AFAIK @adamhavel fixed this, probably not on develop yet

I might have broken something else, will check:)

@enjojoy
Copy link
Contributor Author

enjojoy commented Oct 23, 2024

I have found only this strange design. Not sure it is a related issue. obrazek

AFAIK @adamhavel fixed this, probably not on develop yet

I might have broken something else, will check:)

This branch wasn't rebased on develop for a few days, so maybe it's just not there yet

@adamhavel
Copy link
Contributor

I have found only this strange design. Not sure it is a related issue. obrazek

AFAIK @adamhavel fixed this, probably not on develop yet

I might have broken something else, will check:)

This branch wasn't rebased on develop for a few days, so maybe it's just not there yet

Will you try rebasing it?

@enjojoy
Copy link
Contributor Author

enjojoy commented Oct 23, 2024

I have found only this strange design. Not sure it is a related issue. obrazek

AFAIK @adamhavel fixed this, probably not on develop yet

I might have broken something else, will check:)

This branch wasn't rebased on develop for a few days, so maybe it's just not there yet

Will you try rebasing it?

Yes but not right now, I will let you know in case the issue persists after rebasing.

@enjojoy
Copy link
Contributor Author

enjojoy commented Oct 24, 2024

Seems to be fixed when rebased on develop @adamhavel @adderpositive

image

@enjojoy
Copy link
Contributor Author

enjojoy commented Oct 24, 2024

image

@enjojoy
Copy link
Contributor Author

enjojoy commented Oct 24, 2024 •
edited by tomasklim
Loading

TODO:

  • Remove network warning banner

  • Remove tooltip from address

  • TX model inputs-outputs - component for address, (first 6 and last 4 digits), on hover buttons to copy and show in blockbook.

  • On copy it has a similar modal as when copy in tokens.

  • In modal select between My Tokens and Hidden & Unverified too

  • In modal no search by network.

  • Modal is too long - can be shorter

  • In send form: button Clear All is missing,

  • No currency sign in send field when native token is picked.

  • Full coin amount and fiat

  • remove shadow

  • add unrecognized badge

  • icons to token category picker

  • No balance under Amount

  • Icon size 24

  • Check with figma design

  • check cardano, there is fingerprint and asset id. No contract address, but those two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hermez-cz Hermez-cz Awaiting requested review from Hermez-cz

@adderpositive adderpositive Awaiting requested review from adderpositive

@MiroslavProchazka MiroslavProchazka Awaiting requested review from MiroslavProchazka MiroslavProchazka will be requested when the pull request is marked ready for review MiroslavProchazka is a code owner

@tomasklim tomasklim Awaiting requested review from tomasklim tomasklim will be requested when the pull request is marked ready for review tomasklim is a code owner

@jvaclavik jvaclavik Awaiting requested review from jvaclavik jvaclavik will be requested when the pull request is marked ready for review jvaclavik is a code owner

@adamhavel adamhavel Awaiting requested review from adamhavel adamhavel will be requested when the pull request is marked ready for review adamhavel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVM Tokens / Contract address in send form
3 participants
@enjojoy @adderpositive @adamhavel