Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra{Export,Import} test coverage #136

Closed
aprokop opened this issue Dec 2, 2017 · 9 comments
Closed

Tpetra{Export,Import} test coverage #136

aprokop opened this issue Dec 2, 2017 · 9 comments
Assignees
@tjfulle
Milestone
FY18Q1

Comments

@aprokop
Copy link
Collaborator

aprokop commented Dec 2, 2017

No description provided.

@aprokop aprokop added this to the FY18Q1 milestone Dec 17, 2017
@tjfulle
Copy link
Collaborator

tjfulle commented Dec 17, 2017

@aprokop , I have the tests done. But, to properly test import and export, the doImport and doExport methods of TpetraMultivector, TpetraCrsGraph, and TpetraCrsMatrix need to be implemented. TpetraMultiVector is the priority to push the current tests.

@aprokop
Copy link
Collaborator Author

aprokop commented Dec 17, 2017

Great.

Yes, I've dragging my feet on implementing those. Can't do them automatically (as they belong to the base class), but can do semi-automatically and that should not be hard. Are doImport and doExport of the classes you listed the only things you need?

@tjfulle
Copy link
Collaborator

tjfulle commented Dec 17, 2017

As of right now, yes. The tests I have written are invalid until there is actually something imported/exported to check :)

@tjfulle
Copy link
Collaborator

tjfulle commented Dec 17, 2017

The tests only use TpetraMultiVector

@aprokop
Copy link
Collaborator Author

aprokop commented Dec 17, 2017 •
edited
Loading

I have a patch now that does doImport and doExport, but unfortunately, it does not compile right now due to the clash in zero: some tests define zero, and another zero is coming from Tpetra's CombineMode.

@aprokop
Copy link
Collaborator Author

aprokop commented Dec 17, 2017

Now that #178 is merged, I hope that's sufficient for you to finish the tests.

tjfulle added a commit to tjfulle/ForTrilinos that referenced this issue Dec 17, 2017
@tjfulle
Tpetra: Import/Export unit tests
0cef54f 
Addresses: trilinos#136
@tjfulle tjfulle mentioned this issue Dec 17, 2017
Closed
tjfulle added a commit to tjfulle/ForTrilinos that referenced this issue Dec 17, 2017
@tjfulle
Tpetra: Adding Import/Export tests
49d690c 
Addresses: trilinos#136
@tjfulle tjfulle mentioned this issue Dec 17, 2017
Merged
@aprokop
Copy link
Collaborator Author

aprokop commented Dec 17, 2017

Fixed in #180.

@aprokop aprokop closed this as completed Dec 17, 2017
@aprokop
Copy link
Collaborator Author

aprokop commented Dec 17, 2017

Actually, lets keep it open until we get 100% coverage of the classes.

@aprokop aprokop reopened this Dec 17, 2017
@kruger kruger mentioned this issue Sep 19, 2019
Merged
@aprokop
Copy link
Collaborator Author

aprokop commented Sep 20, 2019

Fixed by #262.

@aprokop aprokop closed this as completed Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjfulle tjfulle

Labels
None yet
Projects
None yet
Milestone
FY18Q1
Development

No branches or pull requests
2 participants
@tjfulle @aprokop