-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling mandatory callbacks for specific methods #494
Comments
I can't think of anything. @sloede ? |
A possible workaround might be |
Solved in #442, right? |
yes, exactly. |
However, the problem is - as discussed in #442 - :
|
Our solution for this now is to reset the flag |
For some methods such as TVF and OpenBC an update each full time step is necessary. That makes the update callback in #440 mandatory for a simulation.
We can't just check , e.g. in the
Semidiscretization
, whether the update callback is in thecallbackset
or not since thecallbackset
is directly passed tosolve
.@efaulhaber @svchb any thoughts on that?
The text was updated successfully, but these errors were encountered: