Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including external headers qualified with project directory names #258

Open
Swat-SomeBug opened this issue Aug 19, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@Swat-SomeBug
Copy link

Hello,
I'm trying to package OpenXLSX for build2 and cppget.org already has some external dependencies.
However, these external dependencies cannot be used as the source files include the headers directly.
Example:

//----- XLCellIterator.cpp ---
// ===== External Includes ===== //
#include <pugixml.hpp>

Would you consider qualifying the headers with the directory name for pugixml and zippy?
For example:

#include <pugixml.hpp> ------------> #include <pugixml/pugixml.hpp>
@aral-matrix
Copy link
Collaborator

Could you elaborate?

I understand build2 is some kind of package manager - which I see has pugixml, but not zippy.

Changing zippy to a depency (as opposed to using the version shipped with OpenXLSX) is not an easy task, as the version in OpenXLSX is customized and probably deviates a lot from any other version.

The pugixml files in OpenXLSX are almost up-to-date with the master (https://github.com/zeux/pugixml) so that might be possible.

Do you want to use the master pugixml? Or do you want OpenXLSX to use it's own pugixml version in a way that it does not cause a conflict with [email protected]?

Could you provide a minimum example of what you need to change in OpenXLSX? Something that you have modified yourself and it works for build2, but with a minimum change in OpenXLSX folder structure?

If you can fork this project & modify what you need, I can have a look at it & discuss it with @troldal

@aral-matrix aral-matrix self-assigned this Aug 21, 2024
@aral-matrix aral-matrix added enhancement New feature or request question Further information is requested labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants