***@***.**** commented on this pull request. ------------------------------ In actuator/src/main/java/org/tron/core/actuator/WithdrawBalanceToActuator.java <#5729 (comment)> : > + } + + boolean isGP = CommonParameter.getInstance() + .getGenesisBlock().getWitnesses().stream().anyMatch(witness -> + Arrays.equals(ownerAddress, witness.getAddress())); + if (isGP) { + throw new ContractValidateException( + ACCOUNT_EXCEPTION_STR + readableOwnerAddress + + "] is a guard representative and is not allowed to withdraw Balance"); + } + + long latestWithdrawTime = accountCapsule.getLatestWithdrawTime(); + long now = dynamicStore.getLatestBlockHeaderTimestamp(); + long witnessAllowanceFrozenTime = dynamicStore.getWitnessAllowanceFrozenTime() * FROZEN_PERIOD; + + if (now - latestWithdrawTime < witnessAllowanceFrozenTime) { Why should we add the frozen time limit? ------------------------------ In actuator/src/main/java/org/tron/core/actuator/WithdrawBalanceToActuator.java <#5729 (comment)> : > + throw new ContractValidateException(e.getMessage()); + } + byte[] ownerAddress = withdrawBalanceToContract.getOwnerAddress().toByteArray(); + if (!DecodeUtil.addressValid(ownerAddress)) { + throw new ContractValidateException("Invalid owner address"); + } + + AccountCapsule accountCapsule = accountStore.get(ownerAddress); + String readableOwnerAddress = StringUtil.createReadableString(ownerAddress); + if (accountCapsule == null) { + throw new ContractValidateException( + ACCOUNT_EXCEPTION_STR + readableOwnerAddress + NOT_EXIST_STR); + } + + byte[] receiverAddress = withdrawBalanceToContract.getReceiverAddress().toByteArray(); + if (!DecodeUtil.addressValid(receiverAddress)) { What if the ownerAddress is equal to the receiverAddress? — Reply to this email directly, view it on GitHub <#5729 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BEAEOAJW3KPK73RXJGLQG33YU32R5AVCNFSM6AAAAABDPAFPASVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJVGE2TAMZSGE> . You are receiving this because you commented.Message ID: ***@***.***>