Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129951 / 24.10 / Clean up system advanced tests #13988

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

yocalebo
Copy link
Contributor

@yocalebo yocalebo commented Jul 8, 2024

  1. test_480 mostly tested the return types of the API endpoints. This is pointless and doesn't test anything meaningful so remove most of the tests
  2. the few functions that tested functionality were combined into 1 test file
  3. I moved another system advanced test (test_system_advanced_login_banner) into this module as well

@yocalebo yocalebo requested a review from a team July 8, 2024 14:49
@bugclerk bugclerk changed the title Clean up system advanced tests NAS-129951 / 24.10 / Clean up system advanced tests Jul 8, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Jul 8, 2024

@yocalebo yocalebo merged commit e28a86a into master Jul 8, 2024
3 checks passed
@yocalebo yocalebo deleted the rem-sys-advanced branch July 8, 2024 18:32
@bugclerk
Copy link
Contributor

bugclerk commented Jul 8, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants