From d667f8b09314dd548b2f5668229fc0df48afcb9c Mon Sep 17 00:00:00 2001 From: Andrew Hobson Date: Fri, 28 Jul 2023 09:28:24 -0400 Subject: [PATCH 1/3] Update pre-commit config with versions that work on arm64 --- .pre-commit-config.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index bfd87bb..fd1128b 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -25,7 +25,7 @@ repos: exclude: README.m(ark)?d(own)? - repo: https://github.com/igorshubovych/markdownlint-cli - rev: v0.33.0 + rev: v0.35.0 hooks: - id: markdownlint @@ -35,6 +35,6 @@ repos: - id: shell-lint - repo: https://github.com/antonbabenko/pre-commit-terraform - rev: v1.77.1 + rev: v1.81.0 hooks: - id: terraform_fmt From c9c35bf076b3a99df3b1fed827d55ede729d8a10 Mon Sep 17 00:00:00 2001 From: Andrew Hobson Date: Fri, 28 Jul 2023 09:31:38 -0400 Subject: [PATCH 2/3] For service discovery, container_{name,port} and port are optional --- variables.tf | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/variables.tf b/variables.tf index d85840f..92da1e9 100644 --- a/variables.tf +++ b/variables.tf @@ -224,12 +224,12 @@ variable "hello_world_container_ports" { } variable "service_registries" { - description = "List of service registry objects as per . List can only have a single object until is resolved." + description = "List of service registry objects as per . List can only have a single object until is resolved. Either provide container_name and container_port or port" type = list(object({ registry_arn = string - container_name = string - container_port = number - port = number + container_name = optional(string) + container_port = optional(number) + port = optional(number) })) default = [] } From 1f5c9461bae430e2ce5bbbef95325e162063062c Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Fri, 28 Jul 2023 13:37:13 +0000 Subject: [PATCH 3/3] terraform-docs: automated action --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5bd9563..41602b5 100644 --- a/README.md +++ b/README.md @@ -179,7 +179,7 @@ No modules. | manage\_ecs\_security\_group | Enable creation and management of the ECS security group and rules | `bool` | `true` | no | | name | The service name. | `string` | n/a | yes | | nlb\_subnet\_cidr\_blocks | List of Network Load Balancer (NLB) CIDR blocks to allow traffic from. | `list(string)` | `[]` | no | -| service\_registries | List of service registry objects as per . List can only have a single object until is resolved. | ```list(object({ registry_arn = string container_name = string container_port = number port = number }))``` | `[]` | no | +| service\_registries | List of service registry objects as per . List can only have a single object until is resolved. Either provide container\_name and container\_port or port | ```list(object({ registry_arn = string container_name = optional(string) container_port = optional(number) port = optional(number) }))``` | `[]` | no | | target\_container\_name | Name of the container the Load Balancer should target. Default: {name}-{environment} | `string` | `""` | no | | tasks\_desired\_count | The number of instances of a task definition. | `number` | `1` | no | | tasks\_maximum\_percent | Upper limit on the number of running tasks. | `number` | `200` | no |