Skip to content
This repository has been archived by the owner on Apr 5, 2023. It is now read-only.

mysql store: several lint errors #86

Open
llorllale opened this issue Oct 23, 2020 · 0 comments
Open

mysql store: several lint errors #86

llorllale opened this issue Oct 23, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@llorllale
Copy link
Contributor

I've been forced to update golangci-lint while working on #75 (because http.Request.Header.Value does not exist in whatever go version is shipped with golangci-lint 1.21) and found these errors:

pkg/storage/mysql/mysqlstore.go:166:30: rows.Err must be checked (rowserrcheck)
        rows, err := newDBConn.Query(
                                    ^
pkg/storage/mysql/mysqlstore.go:318:31: rows.Err must be checked (rowserrcheck)
        resultRows, err := s.db.Query(findQuery)
                                     ^
pkg/storage/mysql/mysqlstore.go:388:30: rows.Err must be checked (rowserrcheck)
        rows, err := indexStmt.Query(s.tableName)
                                    ^
pkg/storage/mysql/mysqlstore.go:383:32: Rows/Stmt was not closed (sqlclosecheck)
        indexStmt, err := s.db.Prepare(getIndexStmt)

This task is a followup to fix these linting issues.

@llorllale llorllale added the bug Something isn't working label Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant