Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in reproducing results from the paper #1

Open
ahmedsohair opened this issue Oct 16, 2024 · 1 comment
Open

Problem in reproducing results from the paper #1

ahmedsohair opened this issue Oct 16, 2024 · 1 comment

Comments

@ahmedsohair
Copy link

The parameters in the sample scripts are different from what's reported in the paper. For example, the clipping constant was proposed to be 0.1 in the paper however, in the scripts it has been set to 20 and 5. Could you please clarify this? Providing a few more materials would help people interested in your paper to reproduce the results:
For example:

-Hyperparameters that were used for the individual experiments at each stage
-Pretrained checkpoints

Thanks!

@Polonez45
Copy link
Contributor

Thanks for your inquiry! Sorry if this wasn't clear, the clipping_constant parameter is actually only used for clipping by norm (ex. see the code blocks for lines 238-243 vs. 244-272 of dp_bart.py), while the clipping by value option was hard-coded and set on lines 158-160, matching the description in the paper (Appendix B). We describe other hyperparameters in detail in Appendix I, which the sample scripts are based on. I have added in the model checkpoints to HF, they are now linked in the Readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants