Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix left and right side of resistor port being drawn differently #122

Open
seveibar opened this issue Nov 13, 2024 · 5 comments
Open

Fix left and right side of resistor port being drawn differently #122

seveibar opened this issue Nov 13, 2024 · 5 comments

Comments

@seveibar
Copy link
Contributor

Likely relevant file: https://github.com/tscircuit/circuit-to-svg/blob/main/lib/sch/svg-object-fns/create-svg-objects-from-sch-component-with-symbol.ts#L201-L202

Image

@seveibar
Copy link
Contributor Author

/bounty $5

Copy link

algora-pbc bot commented Nov 13, 2024

💎 $5 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #122 with your implementation plan
  2. Submit work: Create a pull request including /claim #122 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/circuit-to-svg!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @AkashJana18 Nov 16, 2024, 7:09:58 PM #131

@AkashJana18
Copy link

AkashJana18 commented Nov 16, 2024

/attempt #122

How do i test it?
I couldn't find the contribution guide either to check how can i test it
Can you please guide @seveibar @imrishabh18

@imrishabh18
Copy link
Member

@AkashJana18 To test the specific file use this command bun test <path-of-test-file>. This will create a snapshot of the file in the __snapshots__ directory with the file name .snap.svg. And if there is some difference in the image it will create a .diff.png.

Copy link

algora-pbc bot commented Nov 17, 2024

💡 @AkashJana18 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants