Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot tests for different JSON soup files using bun-match-svg #17

Closed
seveibar opened this issue Aug 21, 2024 · 6 comments · Fixed by #55
Closed

Add snapshot tests for different JSON soup files using bun-match-svg #17

seveibar opened this issue Aug 21, 2024 · 6 comments · Fixed by #55

Comments

@seveibar
Copy link
Contributor

seveibar commented Aug 21, 2024

This isn't super essential because we could use storybook for this with chromatic for visual regression, but since this module is used for visual regressions without storybook it seems like a good idea

Copy link

homie-gg bot commented Aug 21, 2024

Here are some pull requests that might be helpful reference for this task:

Copy link

homie-gg bot commented Aug 23, 2024

This might have already been done via: Added test and snapshot for tssop.

Copy link

homie-gg bot commented Aug 24, 2024

This might have already been done via: Added some missing tests and snapshots.

Copy link

homie-gg bot commented Aug 31, 2024

This might have already been done via: update circuit-to-svg to fix snapshots.

Copy link

homie-gg bot commented Sep 3, 2024

This might have already been done via: WIP convertPcbJsonToTscircuitSoupJson: converrt DSN via element to soup.

@seveibar seveibar changed the title Add snapshot tests for different JSON soup files Add snapshot tests for different JSON soup files using bun-match-svg Sep 9, 2024
Copy link

homie-gg bot commented Sep 9, 2024

This might be a duplicate of: Snapshot tests with bun and @tscircuit/core and bun-match-svg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant