Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autorouter="auto-cloud" violates subcircuit rules (crosses traces) #521

Open
seveibar opened this issue Jan 14, 2025 · 3 comments
Open

autorouter="auto-cloud" violates subcircuit rules (crosses traces) #521

seveibar opened this issue Jan 14, 2025 · 3 comments
Assignees

Comments

@seveibar
Copy link
Contributor

CURRENT BEHAVIOR

Image

EXPECTED BEHAVIOR

Image

REPRODUCTION

export default () => (
  <board width="10mm" height="10mm">
    <group subcircuit autorouter="auto-cloud">
      <resistor
        resistance="1k"
        footprint="0402"
        name="R1"
        schX={3}
        pcbX={3}
        pcbY={3}
      />
      <capacitor
        capacitance="1000pF"
        footprint="0402"
        name="C1"
        schX={-3}
        pcbX={-3}
        pcbY={3}
      />
      <trace from=".R1 > .pin1" to="net.NET1" />
      <trace from=".C1 > .pin1" to="net.NET1" />
    </group>
    <group subcircuit autorouter="auto-cloud">
      <resistor
        resistance="1k"
        footprint="0402"
        name="R1"
        schX={3}
        pcbX={3}
        pcbY={-3}
      />
      <capacitor
        capacitance="1000pF"
        footprint="0402"
        name="C1"
        schX={-3}
        pcbX={-3}
        pcbY={-3}
      />
      <trace from=".R1 > .pin1" to="net.NET1" />
      <trace from=".C1 > .pin1" to="net.NET1" />
    </group>
  </board>
)
@seveibar
Copy link
Contributor Author

/bounty $40

Copy link

algora-pbc bot commented Jan 14, 2025

💎 $40 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #521 with your implementation plan
  2. Submit work: Create a pull request including /claim #521 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/core!

Add a bountyShare on socials

@imrishabh18 imrishabh18 self-assigned this Jan 14, 2025
@imrishabh18
Copy link
Member

@seveibar Our dsn-converter is now fixed and not violating the subcircuit rules as you can take a look here. But we still have a bug with the hover over traces in the image below (just for this edge case), I looked into it and it seems tricky to resolve and taking too much time, most probably some of the current implementation will have to be modified and I don't want to touch a lot of stuff in there cause currently everything is working fine, and anyways this is a specific edge case where both the subcircuit having the same variable name and not getting connected directly to each other and rather through the net. I think we can close this issue for now and create a new issue for this specific bug (can be looked later on). Thoughts?

https://tscircuit.com/editor?&snippet_type=board#data:application/gzip;base64,H4sIAOivh2cAA9WTsU7DMBCG9z7FyVM7NHGAMc5SwchQMcDoOE5j0diWcxZIiHfnKFZSkSKYUCtlyH3+z/7kk/WrdwGh0a2Me4TlCkQFywUAfWXtZGjgxTTYCVbwvmfQabPrMFUVhSi2Cy56GGKtTFDRIMiIjhjqINjn/1rtXWxSnBqCHsxAkVQDfAFplaadn9nIW+fQB2PpQH7Dr6YFK3uKbouJDKp7FG/X7yPwqp6BpyOQjzpKeqnMsU8iSYhz7u/+LLWZSa1nVt/IaS0MUmlog+sFy7YFVJB5YwsG6ASzGrP72weqfmjY/NZQ5oe5XeIMp+s7ryGe8vq/KZb54b1Wi9UHFl7b+NUDAAA=

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants